]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-29097: Forego fold detection on windows for low timestamp values (GH-2385) (GH...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 25 Jul 2018 20:34:09 +0000 (13:34 -0700)
committerAlexander Belopolsky <abalkin@users.noreply.github.com>
Wed, 25 Jul 2018 20:34:09 +0000 (16:34 -0400)
commit973649342cee3869409f341ff0f0e3d2b1547c2a
tree52d9f032b7e407c1a2ef109ffc9df3daada6b4d6
parentec02c58f5a6fdb06b769f53255fcb5d393812160
bpo-29097: Forego fold detection on windows for low timestamp values (GH-2385) (GH-8466)

On Windows, passing a negative value to local results in an OSError because localtime_s on Windows does not support negative timestamps. Unfortunately this means that fold detection for timestamps between 0 and max_fold_seconds will result in this OSError since we subtract max_fold_seconds from the timestamp to detect a fold. However, since we know there haven't been any folds in the interval [0, max_fold_seconds) in any timezone, we can hackily just forego fold detection for this time range on Windows.
(cherry picked from commit 96d1e69a12ed8ab80203277e1abdaf573457a964)

Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
Lib/datetime.py
Lib/test/datetimetester.py
Misc/NEWS.d/next/Windows/2018-05-16-11-31-17.bpo-29097.9mqEuI.rst [new file with mode: 0644]
Modules/_datetimemodule.c