]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
inet_diag: validate port comparison byte code to prevent unsafe reads
authorNeal Cardwell <ncardwell@google.com>
Sun, 9 Dec 2012 11:09:54 +0000 (11:09 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2012 17:27:19 +0000 (09:27 -0800)
commit973e442c150c34d5b20a7e20f514aea515053f85
treef7f49f5fb26481576337e5e131ca567121673449
parent38a5e42f97db0bdc47f6f5128777cc6f09ed5669
inet_diag: validate port comparison byte code to prevent unsafe reads

[ Upstream commit 5e1f54201cb481f40a04bc47e1bc8c093a189e23 ]

Add logic to verify that a port comparison byte code operation
actually has the second inet_diag_bc_op from which we read the port
for such operations.

Previously the code blindly referenced op[1] without first checking
whether a second inet_diag_bc_op struct could fit there. So a
malicious user could make the kernel read 4 bytes beyond the end of
the bytecode array by claiming to have a whole port comparison byte
code (2 inet_diag_bc_op structs) when in fact the bytecode was not
long enough to hold both.

Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/inet_diag.c