]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
closes bpo-39510: Fix use-after-free in BufferedReader.readinto() (GH-18295)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 4 Feb 2020 21:43:07 +0000 (13:43 -0800)
committerGitHub <noreply@github.com>
Tue, 4 Feb 2020 21:43:07 +0000 (13:43 -0800)
commit97d2a9832494e4c85da124ceab18802eed9a4ab1
treeffaeef139bac1bad4224404ba44d7c98d9f5a41d
parentfda6593f926be274225dc4bcfdc3f96d9f40258f
closes bpo-39510: Fix use-after-free in BufferedReader.readinto() (GH-18295)

When called on a closed object, readinto() segfaults on account
of a write to a freed buffer:

    ==220553== Process terminating with default action of signal 11 (SIGSEGV): dumping core
    ==220553==  Access not within mapped region at address 0x2A
    ==220553==    at 0x48408A0: memmove (vg_replace_strmem.c:1272)
    ==220553==    by 0x58DB0C: _buffered_readinto_generic (bufferedio.c:972)
    ==220553==    by 0x58DCBA: _io__Buffered_readinto_impl (bufferedio.c:1053)
    ==220553==    by 0x58DCBA: _io__Buffered_readinto (bufferedio.c.h:253)

Reproducer:

    reader = open ("/dev/zero", "rb")
    _void  = reader.read (42)
    reader.close ()
    reader.readinto (bytearray (42)) GH-GH-GH- BANG!

The problem exists since 2012 when commit dc469454ec added code
to free the read buffer on close().

Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
(cherry picked from commit cb1c0746f277052e45a60d6c436a765e34722821)

Co-authored-by: Philipp Gesang <phg@phi-gamma.net>
Lib/test/test_io.py
Misc/NEWS.d/next/Core and Builtins/2020-02-04-10-27-41.bpo-39510.PMIh-f.rst [new file with mode: 0644]
Modules/_io/bufferedio.c