]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/xe/oa: Move default oa unit assignment earlier during stream open
authorAshutosh Dixit <ashutosh.dixit@intel.com>
Fri, 12 Dec 2025 06:18:48 +0000 (22:18 -0800)
committerAshutosh Dixit <ashutosh.dixit@intel.com>
Thu, 18 Dec 2025 03:47:28 +0000 (19:47 -0800)
commit97e16068d77a036908f69aba35486b21dee17a40
tree2f142023b1eb5736ad11e6062af538be11d780f4
parent487524c891d3cc21eb6d243c2885273c5b142b44
drm/xe/oa: Move default oa unit assignment earlier during stream open

De-referencing param.oa_unit, when an OA unit id is not provided during
stream open, results in NPD below.

  Oops: general protection fault, probably for non-canonical address...
  KASAN: null-ptr-deref in range...
  RIP: 0010:xe_oa_stream_open_ioctl+0x169/0x38a0
   xe_observation_ioctl+0x19f/0x270
   drm_ioctl_kernel+0x1f4/0x410

Fix this by moving default oa unit assignment before the dereference.

Reported-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6840
Fixes: c7e269aa565f ("drm/xe/oa: Allow exec_queue's to be specified only for OAG OA unit")
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Harish Chegondi <harish.chegondi@intel.com>
Link: https://patch.msgid.link/20251212061850.1565459-2-ashutosh.dixit@intel.com
drivers/gpu/drm/xe/xe_oa.c