]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selftests: forwarding: Fix layer 2 miss test flakiness
authorIdo Schimmel <idosch@nvidia.com>
Thu, 8 Feb 2024 15:55:26 +0000 (17:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Feb 2024 08:51:25 +0000 (09:51 +0100)
commit98107e06934d9794efd1ce4e7efeeccf3db2c085
treee63209b74fa6bed89345410ddae7f26866ebfd70
parentf93abb38944727bfcf6c12525dd0fbdbff0752bf
selftests: forwarding: Fix layer 2 miss test flakiness

[ Upstream commit 93590849a05edffaefa11695fab98f621259ded2 ]

After enabling a multicast querier on the bridge (like the test is
doing), the bridge will wait for the Max Response Delay before starting
to forward according to its MDB in order to let Membership Reports
enough time to be received and processed.

Currently, the test is waiting for exactly the default Max Response
Delay (10 seconds) which is racy and leads to failures [1].

Fix by reducing the Max Response Delay to 1 second.

[1]
 [...]
 # TEST: L2 miss - Multicast (IPv4)                                    [FAIL]
 # Unregistered multicast filter was hit after adding MDB entry

Fixes: 8c33266ae26a ("selftests: forwarding: Add layer 2 miss test cases")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://lore.kernel.org/r/20240208155529.1199729-2-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh