]>
git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_fsr: Fix parentheses around truth value
Someone in the distant past must have responded to gcc's
warning about parentheses around assignment used as a truth
value by changing:
while (ret = func() == 0)
to:
while ((ret = func() == 0))
While this shuts up gcc, it doesn't yield the proper result.
If func () returns 0, func == 0 is true, and ret is assigned
a value of 1.
This does keep the while loop going, but it's a very strange
way to go about it, and may someday yield confusing results.
Fix this as:
while ((ret = func()) == 0)
so that ret gets the function return value as expected.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>