]> git.ipfire.org Git - thirdparty/linux.git/commit
spi: fsl-qspi: Use reinit_completion() for repeated operations
authorFelix Gu <ustc.gu@gmail.com>
Wed, 4 Mar 2026 12:47:21 +0000 (20:47 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 9 Mar 2026 20:12:06 +0000 (20:12 +0000)
commit981b080a79724738882b0af1c5bb7ade30d94f24
tree614284b9eefe17fa38f6b18396df42fb17cd61a3
parent68c8c93fdb0de7e528dc3dfb1d17eb0f652259b8
spi: fsl-qspi: Use reinit_completion() for repeated operations

The driver currently calls init_completion() during every spi_mem_op.
Tchnically it may work, but it's not the recommended pattern.

According to the kernel documentation: Calling init_completion() on
the same completion object twice is most likely a bug as it
re-initializes the queue to an empty queue and enqueued tasks could
get "lost" - use reinit_completion() in that case, but be aware of
other races.

So moves the initial initialization to probe function and uses
reinit_completion() for subsequent operations.

Fixes: 84d043185dbe ("spi: Add a driver for the Freescale/NXP QuadSPI controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Link: https://patch.msgid.link/20260304-spi-nxp-v2-3-cd7d7726a27e@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-qspi.c