]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
adjust MySQL view reflection for non-standard MySQL variants
authorJohn Bodley <4567245+john-bodley@users.noreply.github.com>
Fri, 30 Sep 2022 01:58:58 +0000 (21:58 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 3 Oct 2022 22:08:08 +0000 (18:08 -0400)
commit9829bc43d69ea5e714014f5ac5f036a94d13bc08
tree059391d5d165b1840588ad83eee50035f1e05c68
parentbb76f256fc235e2ffcdfa79cdf33a810eac8f7b2
adjust MySQL view reflection for non-standard MySQL variants

Adjusted the regular expression used to match "CREATE VIEW" when
testing for views to work more flexibly, no longer requiring the
special keyword "ALGORITHM" in the middle, which was intended to be
optional but was not working correctly.  The change allows view reflection
to work more completely on MySQL-compatible variants such as StarRocks.
Pull request courtesy John Bodley.

Fixes: #8588
Closes: #8589
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8589
Pull-request-sha: d85b2c5b51e45cec543c9ae9d62d6d659b063354

Change-Id: I173137f0bf68639cad0d5c329055475b40ddb5e4
doc/build/changelog/unreleased_14/8588.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/mysql/base.py
lib/sqlalchemy/dialects/mysql/reflection.py
test/dialect/mysql/test_reflection.py