]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Don't start a nested job in qemuMigrationPrepareAny
authorJán Tomko <jtomko@redhat.com>
Tue, 19 Nov 2013 17:03:21 +0000 (18:03 +0100)
committerJán Tomko <jtomko@redhat.com>
Fri, 22 Nov 2013 15:22:31 +0000 (16:22 +0100)
commit98464021167377bc7373b4d3951b1e868f8db291
treea38530b8314d8f62f701c765811c73ff19bfb327
parentd65e0e1466b09964b85c79b8cc78be454df53583
Don't start a nested job in qemuMigrationPrepareAny

This nested job is canceled by the first ExitMonitor call (even though
it was not created by the corresponding EnterMonitor call), and
again in qemuMigrationPrepareAny if qemuProcessStart failed.
This can lead to a crash if the vm object was disposed of before calling
qemuDomainRemoveInactive:
0  ..62bc in virClassIsDerivedFrom (klass=0xdeadbeef,
   parent=0x7ffce4cdd270) at util/virobject.c:166
1 ..6666 in virObjectIsClass at util/virobject.c:362
2 ..66b4 in virObjectLock at util/virobject.c:314
3 ..477e in virDomainObjListRemove at conf/domain_conf.c:2359
4 ..7a64 in qemuDomainRemoveInactive at qemu/qemu_domain.c:2087
5 ..956c in qemuMigrationPrepareAny at qemu/qemu_migration.c:2469

This was added by commit e4e2822, exposed by 5a4c237 and c7ac251.

https://bugzilla.redhat.com/show_bug.cgi?id=1018267
src/qemu/qemu_migration.c