]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtnl/bond: don't send rtnl msg for unregistered iface
authorNicolas Dichtel <nicolas.dichtel@6wind.com>
Wed, 13 May 2015 12:19:42 +0000 (14:19 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 15 Jun 2015 18:26:49 +0000 (14:26 -0400)
commit984ff7a3e0603d4bc472ad09f4f119089085d8ca
treebaaf5c82e4624c6e53322c3eef9c43ea126f473c
parentb23b97ca70a9fe03bb3e3e74bc8d120b0e15e4fb
rtnl/bond: don't send rtnl msg for unregistered iface

[ Upstream commit ed2a80ab7b76f11af0b2c6255709c4ebf164b667 ]

Before the patch, the command 'ip link add bond2 type bond mode 802.3ad'
causes the kernel to send a rtnl message for the bond2 interface, with an
ifindex 0.

'ip monitor' shows:
0: bond2: <BROADCAST,MULTICAST,MASTER> mtu 1500 state DOWN group default
    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
9: bond2@NONE: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN group default
    link/ether ea:3e:1f:53:92:7b brd ff:ff:ff:ff:ff:ff
[snip]

The patch fixes the spotted bug by checking in bond driver if the interface
is registered before calling the notifier chain.
It also adds a check in rtmsg_ifinfo() to prevent this kind of bug in the
future.

Fixes: d4261e565000 ("bonding: create netlink event when bonding option is changed")
CC: Jiri Pirko <jiri@resnulli.us>
Reported-by: Julien Meunier <julien.meunier@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/net/bonding/bond_options.c
net/core/rtnetlink.c