]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netem: Update sch->q.qlen before qdisc_tree_reduce_backlog()
authorCong Wang <cong.wang@bytedance.com>
Tue, 4 Feb 2025 00:58:40 +0000 (16:58 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:23 +0000 (12:50 +0100)
commit98a2c685293aae122f688cde11d9334dddc5d207
treee8a524b6cfa6caccc2db5a2e715e0615a9974916
parentd85d721f32251c48eed3a1d9bb63db7b32550464
netem: Update sch->q.qlen before qdisc_tree_reduce_backlog()

[ Upstream commit 638ba5089324796c2ee49af10427459c2de35f71 ]

qdisc_tree_reduce_backlog() notifies parent qdisc only if child
qdisc becomes empty, therefore we need to reduce the backlog of the
child qdisc before calling it. Otherwise it would miss the opportunity
to call cops->qlen_notify(), in the case of DRR, it resulted in UAF
since DRR uses ->qlen_notify() to maintain its active list.

Fixes: f8d4bc455047 ("net/sched: netem: account for backlog updates from child qdisc")
Cc: Martin Ottens <martin.ottens@fau.de>
Reported-by: Mingi Cho <mincho@theori.io>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Link: https://patch.msgid.link/20250204005841.223511-4-xiyou.wangcong@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_netem.c