]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/panthor: Fix UAF on kernel BO VA nodes
authorBoris Brezillon <boris.brezillon@collabora.com>
Fri, 31 Oct 2025 15:48:15 +0000 (16:48 +0100)
committerLiviu Dudau <liviu.dudau@arm.com>
Mon, 3 Nov 2025 14:25:22 +0000 (14:25 +0000)
commit98dd5143447af0ee33551776d8b2560c35d0bc4a
tree77b4fc709c2ff168ed15c32409b1c999ba188e61
parent08be57e6e8aa20ea5a6dd2552e38ac168d6a9b11
drm/panthor: Fix UAF on kernel BO VA nodes

If the MMU is down, panthor_vm_unmap_range() might return an error.
We expect the page table to be updated still, and if the MMU is blocked,
the rest of the GPU should be blocked too, so no risk of accessing
physical memory returned to the system (which the current code doesn't
cover for anyway).

Proceed with the rest of the cleanup instead of bailing out and leaving
the va_node inserted in the drm_mm, which leads to UAF when other
adjacent nodes are removed from the drm_mm tree.

Reported-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Closes: https://gitlab.freedesktop.org/panfrost/linux/-/issues/57
Fixes: 8a1cc07578bf ("drm/panthor: Add GEM logical block")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patch.msgid.link/20251031154818.821054-2-boris.brezillon@collabora.com
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
drivers/gpu/drm/panthor/panthor_gem.c