]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5e: Don't print error message due to invalid module
authorGal Pressman <gal@nvidia.com>
Thu, 25 Dec 2025 13:27:16 +0000 (15:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Jan 2026 15:39:31 +0000 (16:39 +0100)
commit98f4d7e2c6dd2f27d7798ca68e418cb27b3dac6e
treea9b30cda68510c1ff6acd9a758fcc4ee87ad2b8a
parent806a0d964e27681dd8b82370382484bddf60474c
net/mlx5e: Don't print error message due to invalid module

[ Upstream commit 144297e2a24e3e54aee1180ec21120ea38822b97 ]

Dumping module EEPROM on newer modules is supported through the netlink
interface only.

Querying with old userspace ethtool (or other tools, such as 'lshw')
which still uses the ioctl interface results in an error message that
could flood dmesg (in addition to the expected error return value).
The original message was added under the assumption that the driver
should be able to handle all module types, but now that such flows are
easily triggered from userspace, it doesn't serve its purpose.

Change the log level of the print in mlx5_query_module_eeprom() to
debug.

Fixes: bb64143eee8c ("net/mlx5e: Add ethtool support for dump module EEPROM")
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
Link: https://patch.msgid.link/20251225132717.358820-5-mbloch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/port.c