]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
hwmon: (ads7871) Fix endianness bug in 16-bit register reads
authorTabrez Ahmed <tabreztalks@gmail.com>
Sat, 2 May 2026 02:08:42 +0000 (07:38 +0530)
committerGuenter Roeck <linux@roeck-us.net>
Thu, 7 May 2026 23:30:12 +0000 (16:30 -0700)
commit99076a17a112ac43cbd37f6883898ae649166303
treed0288446ee8cc6e671be1f4ab5dd2b2e9e6ad450
parent05aaac8746c5786eaa779b163fae4ddcd5172707
hwmon: (ads7871) Fix endianness bug in 16-bit register reads

The ads7871_read_reg16() function relies on spi_w8r16() to read the
16-bit sensor output. The ADS7871 device transmits the Least Significant
Byte (LSB) first.

On Little-Endian architectures, spi_w8r16() correctly reconstructs the
16-bit value. However, on Big-Endian architectures, the byte swapping
causes the first received byte (LSB) to be placed in the most significant
byte of the u16, resulting in corrupted voltage readings.

To fix this, cast the integer result of spi_w8r16() to a restricted
__le16 type and convert it to the host CPU's native byte order using
le16_to_cpu(). Negative error codes returned by the SPI core are caught
and returned prior to the conversion to avoid mangling the error status.

Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/patchset/20260418034601.90226-1-tabreztalks@gmail.com
Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
Suggested-by: David Laight <david.laight.linux@gmail.com>
Signed-off-by: Tabrez Ahmed <tabreztalks@gmail.com>
Link: https://lore.kernel.org/r/20260502020844.110038-2-tabreztalks@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ads7871.c