]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
md/raid1: fix_read_error should act on all non-faulty devices.
authorNeilBrown <neilb@suse.de>
Thu, 18 Sep 2014 01:09:04 +0000 (11:09 +1000)
committerJiri Slaby <jslaby@suse.cz>
Mon, 13 Oct 2014 13:41:38 +0000 (15:41 +0200)
commit995925f1ecd8c80bb265153119362c495648a91e
tree4e9e159e8562e95c6f680c08473e5cf9fa9dad7b
parente1a45c6066dc65d03dd5a56b75c6baab813d9c1b
md/raid1: fix_read_error should act on all non-faulty devices.

commit b8cb6b4c121e1bf1963c16ed69e7adcb1bc301cd upstream.

If a devices is being recovered it is not InSync and is not Faulty.

If a read error is experienced on that device, fix_read_error()
will be called, but it ignores non-InSync devices.  So it will
neither fix the error nor fail the device.

It is incorrect that fix_read_error() ignores non-InSync devices.
It should only ignore Faulty devices.  So fix it.

This became a bug when we allowed reading from a device that was being
recovered.  It is suitable for any subsequent -stable kernel.

Fixes: da8840a747c0dbf49506ec906757a6b87b9741e9
Reported-by: Alexander Lyakas <alex.bolshoy@gmail.com>
Tested-by: Alexander Lyakas <alex.bolshoy@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/md/raid1.c