]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/mlx5e: Fix features not applied during netdev registration
authorGal Pressman <gal@nvidia.com>
Thu, 9 Apr 2026 20:28:51 +0000 (23:28 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sun, 12 Apr 2026 21:37:08 +0000 (14:37 -0700)
commit9994ad4df82d64e57135c0f0906897685f5a9e87
treec4969adf0823f1bf0ae668622500b24e1e1363b2
parentd114bfdc9b76bf93b881e195b7ec957c14227bab
net/mlx5e: Fix features not applied during netdev registration

mlx5e_fix_features() returns early when the netdevice is not present.
This is correct during profile transitions where priv is cleared, but it
also incorrectly blocks feature fixups during register_netdev(), when
the device is also not yet present.

It is not trivial to distinguish between both cases as we cannot use
priv to carry state, and in both cases reg_state == NETREG_REGISTERED.

Force a netdev features update after register_netdev() completes, where
the device is present and fix_features() can actually work.

This is not a pretty solution, as it results in an additional features
update call (register_netdevice() already calls
__netdev_update_features() internally), but it is the simplest,
cleanest, and most robust way I found to fix this issue after multiple
attempts.

This fixes an issue on systems where CQE compression is enabled by
default, RXHASH remains enabled after registration despite the two
features being mutually exclusive.

Fixes: ab4b01bfdaa6 ("net/mlx5e: Verify dev is present for fix features ndo")
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260409202852.158059-2-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c