]> git.ipfire.org Git - thirdparty/gcc.git/commit
c++: P2280R4, Using unknown refs in constant expr [PR106650]
authorMarek Polacek <polacek@redhat.com>
Fri, 17 Nov 2023 19:48:44 +0000 (14:48 -0500)
committerMarek Polacek <polacek@redhat.com>
Wed, 29 Nov 2023 22:08:16 +0000 (17:08 -0500)
commit99d114c15523e0bfe7a89ef1947f82eb5ff0260b
treec5a65f6de92f0d612a381fc44cf832f5fe662cd8
parent8b2e510ca3158bac5553e90cd9d856a5db5dafb7
c++: P2280R4, Using unknown refs in constant expr [PR106650]

This patch is an attempt to implement (part of?) P2280, Using unknown
pointers and references in constant expressions.  (Note that R4 seems to
only allow References to unknown/Accesses via this, but not Pointers to
unknown.)

This patch works to the extent that the test case added in [expr.const]
works as expected, as well as the test in
<https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html#the-this-pointer>

Most importantly, the proposal makes this compile:

  template <typename T, size_t N>
  constexpr auto array_size(T (&)[N]) -> size_t {
      return N;
  }

  void check(int const (&param)[3]) {
      constexpr auto s = array_size(param);
      static_assert (s == 3);
  }

and I think it would be a pity not to have it in GCC 14.

What still doesn't work is the test in $3.2:

  struct A2 { constexpr int f() { return 0; } };
  struct B2 : virtual A2 {};
  void f2(B2 &b) { constexpr int k = b.f(); }

where we say
error: '* & b' is not a constant expression

This will be fixed in the future.

PR c++/106650

gcc/cp/ChangeLog:

* constexpr.cc (cxx_eval_constant_expression) <case PARM_DECL>: Allow
reference to unknown/this as per P2280.
<case VAR_DECL>: Allow reference to unknown as per P2280.

gcc/testsuite/ChangeLog:

* g++.dg/cpp0x/constexpr-array-ptr6.C: Remove dg-error.
* g++.dg/cpp0x/constexpr-ref12.C: Likewise.
* g++.dg/cpp0x/constexpr-ref2.C: Adjust dg-error.
* g++.dg/cpp0x/noexcept34.C: Remove dg-error.
* g++.dg/cpp1y/lambda-generic-const10.C: Likewise.
* g++.dg/cpp0x/constexpr-ref13.C: New test.
* g++.dg/cpp1z/constexpr-ref1.C: New test.
* g++.dg/cpp1z/constexpr-ref2.C: New test.
* g++.dg/cpp2a/constexpr-ref1.C: New test.
gcc/cp/constexpr.cc
gcc/testsuite/g++.dg/cpp0x/constexpr-array-ptr6.C
gcc/testsuite/g++.dg/cpp0x/constexpr-ref12.C
gcc/testsuite/g++.dg/cpp0x/constexpr-ref13.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp0x/constexpr-ref2.C
gcc/testsuite/g++.dg/cpp0x/noexcept34.C
gcc/testsuite/g++.dg/cpp1y/lambda-generic-const10.C
gcc/testsuite/g++.dg/cpp1z/constexpr-ref1.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp1z/constexpr-ref2.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp2a/constexpr-ref1.C [new file with mode: 0644]