]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033)
authorZackery Spytz <zspytz@gmail.com>
Sat, 8 Dec 2018 14:16:55 +0000 (07:16 -0700)
committerSerhiy Storchaka <storchaka@gmail.com>
Sat, 8 Dec 2018 14:16:55 +0000 (16:16 +0200)
commit99d56b53560b3867844472ae381fb3f858760621
treef81865ef12567f144d7eaf3adf8b61c136945a55
parentf05df0a4b679d0acfd0b1fe6187ba2d553b37afa
bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033)

In _localemodule.c and selectmodule.c, remove dead code that would
cause double decrefs if run.

In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
where a new list is populated and there is no possibility of an error.

In addition, check if the list changed size in the loop in array_array_fromlist().
Modules/_localemodule.c
Modules/arraymodule.c
Modules/readline.c
Modules/selectmodule.c
PC/winreg.c
Python/ceval.c
Python/sysmodule.c