]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX
authorKuan-Wei Chiu <visitorckw@gmail.com>
Sat, 28 Sep 2024 11:36:08 +0000 (19:36 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Feb 2025 12:49:30 +0000 (13:49 +0100)
commit9a6d43844de2479a3ff8d674c3e2a16172e01598
treeb69f17f867cbf6e31517e6ec66653d2c7c156f7f
parentb04b69819bc93c8e81da153067f1b25aa3b8cd8f
printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX

[ Upstream commit 3d6f83df8ff2d5de84b50377e4f0d45e25311c7a ]

Shifting 1 << 31 on a 32-bit int causes signed integer overflow, which
leads to undefined behavior. To prevent this, cast 1 to u32 before
performing the shift, ensuring well-defined behavior.

This change explicitly avoids any potential overflow by ensuring that
the shift occurs on an unsigned 32-bit integer.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Acked-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20240928113608.1438087-1-visitorckw@gmail.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/printk/printk.c