]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mvsas: fix panic on expander attached SATA devices
authorJames Bottomley <JBottomley@Odin.com>
Thu, 16 Apr 2015 05:16:01 +0000 (22:16 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 May 2015 20:02:00 +0000 (22:02 +0200)
commit9ab8410129181585500e397d9d09c45fee86584d
tree23bd3d75af3635c9cd640f101afa63b56c327f48
parent5cc4c31815bb2e9035fe44287c8e42a862cefc7e
mvsas: fix panic on expander attached SATA devices

commit 56cbd0ccc1b508de19561211d7ab9e1c77e6b384 upstream.

mvsas is giving a General protection fault when it encounters an expander
attached ATA device.  Analysis of mvs_task_prep_ata() shows that the driver is
assuming all ATA devices are locally attached and obtaining the phy mask by
indexing the local phy table (in the HBA structure) with the phy id.  Since
expanders have many more phys than the HBA, this is causing the index into the
HBA phy table to overflow and returning rubbish as the pointer.

mvs_task_prep_ssp() instead does the phy mask using the port properties.
Mirror this in mvs_task_prep_ata() to fix the panic.

Reported-by: Adam Talbot <ajtalbot1@gmail.com>
Tested-by: Adam Talbot <ajtalbot1@gmail.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/mvsas/mv_sas.c