]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix synchronized_standby_slots GUC check hook
authorÁlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 3 Dec 2024 16:50:57 +0000 (17:50 +0100)
committerÁlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 3 Dec 2024 16:50:57 +0000 (17:50 +0100)
commit9abdc1841e16ff4eaf2fa8e2e0472ee71a4a5a5c
treeb00d253ee8bf79f89c966135c5a02060ed87fdee
parent5ffbbcfa160b2e689dfb0542dfdbc4e16fc0dec9
Fix synchronized_standby_slots GUC check hook

The validate_sync_standby_slots subroutine requires an LWLock, so it
cannot run in processes without PGPROC; skip it there to avoid a crash.

This replaces the current test for ReplicationSlotCtl being not null,
which appears to be a solution for the same problem but less general.
I also rewrote a related comment that mentioned ReplicationSlotCtl in
StandbySlotsHaveCaughtup.

This code came in with commit bf279ddd1c28; backpatch to 17.

Reported-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/202411281216.sutbxtr6idnn@alvherre.pgsql
src/backend/replication/slot.c