]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mtd: spinand: Do not erase the block before writing a bad block marker
authorFrieder Schrempf <frieder.schrempf@kontron.de>
Tue, 18 Feb 2020 10:05:35 +0000 (10:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Apr 2020 14:12:07 +0000 (16:12 +0200)
commit9add33b7e596c2088d7974138a979a121cf2835a
tree947cbd994c40907d3f786683ceda41fabb975d75
parent501c512cd893ca7daf71e2e6d5f301ef263564d7
mtd: spinand: Do not erase the block before writing a bad block marker

commit b645ad39d56846618704e463b24bb994c9585c7f upstream.

Currently when marking a block, we use spinand_erase_op() to erase
the block before writing the marker to the OOB area. Doing so without
waiting for the operation to finish can lead to the marking failing
silently and no bad block marker being written to the flash.

In fact we don't need to do an erase at all before writing the BBM.
The ECC is disabled for raw accesses to the OOB data and we don't
need to work around any issues with chips reporting ECC errors as it
is known to be the case for raw NAND.

Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Cc: stable@vger.kernel.org
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200218100432.32433-4-frieder.schrempf@kontron.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/nand/spi/core.c