]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: apple: Fix stuck function keys when using FN
authorJoao Moreno <mail@joaomoreno.com>
Tue, 3 Sep 2019 14:46:32 +0000 (16:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 19:01:02 +0000 (21:01 +0200)
commit9b3458c19b1a74e3e70d8ae1acc86f77fd1ef624
tree331409a4aca4673ece77853d2004881c4aa761df
parent29f62e3db89f559e2adbb4819abd7d8f82c3c734
HID: apple: Fix stuck function keys when using FN

[ Upstream commit aec256d0ecd561036f188dbc8fa7924c47a9edfd ]

This fixes an issue in which key down events for function keys would be
repeatedly emitted even after the user has raised the physical key. For
example, the driver fails to emit the F5 key up event when going through
the following steps:
- fnmode=1: hold FN, hold F5, release FN, release F5
- fnmode=2: hold F5, hold FN, release F5, release FN

The repeated F5 key down events can be easily verified using xev.

Signed-off-by: Joao Moreno <mail@joaomoreno.com>
Co-developed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-apple.c