]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Mon, 26 May 2025 14:07:47 +0000 (17:07 +0300)
committerTakashi Iwai <tiwai@suse.de>
Mon, 9 Jun 2025 07:48:51 +0000 (09:48 +0200)
commit9cea7425595697802e8d55a322a251999554b8b1
tree2c6f1a4c5f1ad654d6395b2ed52ae39b3151ebce
parentf2d6d660e8fd5f4467e80743f82119201e67fa9c
ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks

Adding a memory barrier before wake_up() in
snd_usb_soundblaster_remote_complete() is supposed to ensure the write
to mixer->rc_code is visible in wait_event_interruptible() from
snd_usb_sbrc_hwdep_read().

However, this is not really necessary, since wake_up() is just a wrapper
over __wake_up() which already executes a full memory barrier before
accessing the state of the task to be waken up.

Drop the redundant call to wmb() and implicitly fix the checkpatch
complaint:

  WARNING: memory barrier without comment

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250526-dualsense-alsa-jack-v1-8-1a821463b632@collabora.com
sound/usb/mixer_quirks.c