]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Undo thinko in commit e78d1d6d4.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 10 Jun 2026 21:01:45 +0000 (17:01 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 10 Jun 2026 21:01:45 +0000 (17:01 -0400)
commit9d141466ff087230571e9c9dfd720deb94977253
tree8aa48d5faa21015228440b3d795ce6a6e5965736
parente18b0cb7344cb4bd28468f6c0aeeb9b9241d30aa
Undo thinko in commit e78d1d6d4.

In pursuit of removing a Valgrind-detected leak, I inserted
"pfree(pq_mq_handle);" into mq_putmessage's recursion-trouble-recovery
code path, failing to notice that shm_mq_detach would have pfree'd
that block just before (i.e., this particular code path did not leak).
So now that was a double pfree.  We didn't notice because the
recursion scenario isn't exercised in our regression tests, but
Alexander Lakhin found it via code fuzzing.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/b8b40954-e155-41b3-9af8-ad4f261a1b64@gmail.com
src/backend/libpq/pqmq.c