]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
regulator: scmi: Use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Fri, 29 Aug 2025 10:14:11 +0000 (18:14 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 1 Sep 2025 13:04:18 +0000 (14:04 +0100)
commit9d35d068fb138160709e04e3ee97fe29a6f8615b
tree825275f5c155f0eee4bca04d1ce1d9488e332589
parent899fb38dd76dd3ede425bbaf8a96d390180a5d1c
regulator: scmi: Use int type to store negative error codes

Change the 'ret' variable from u32 to int to store negative error codes or
zero returned by of_property_read_u32().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Fixes: 0fbeae70ee7c ("regulator: add SCMI driver")
Link: https://patch.msgid.link/20250829101411.625214-1-rongqianfeng@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/scmi-regulator.c