]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Pass all pool parameters in recreate()
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 14 Sep 2020 14:14:48 +0000 (10:14 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 14 Sep 2020 15:37:13 +0000 (11:37 -0400)
commit9d4c15a8da2e9d30d84fbe1cef3e45832a64bf96
tree129eda2e3f292eb9f4b0a50fd50f4d8c6587cc37
parent97bafe930e9dd12841cf0bba67f53c2d6cb0ddde
Pass all pool parameters in recreate()

The following pool parameters were not being propagated to the new pool
created when :meth:`_engine.Engine.dispose` were called: ``pre_ping``,
``use_lifo``.  Additionally the ``recycle`` and ``reset_on_return``
parameters were not propagated for the :class:`_engine.AssertionPool`
class.  These issues have been fixed.

Fixes: #5582
Change-Id: Ifdb703aa7e849652242b9ff8071c854cd1d77e71
(cherry picked from commit 3d803a8ed3e07332dff872180680bed6175dd483)
doc/build/changelog/unreleased_13/5582.rst [new file with mode: 0644]
lib/sqlalchemy/pool/impl.py
test/engine/test_pool.py