]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.14] gh-132835: Add defensive NULL checks to MRO resolution (GH-134763) (GH-140436)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 22 Oct 2025 03:45:06 +0000 (05:45 +0200)
committerGitHub <noreply@github.com>
Wed, 22 Oct 2025 03:45:06 +0000 (20:45 -0700)
commit9d547dab0bb59adcd969172ef8e69540668db6a0
tree1b6dc7dcdba17100dd1462d4c0451903fe7dff1e
parenta490d671fad24859a31afdb7a64f090deb3346c2
[3.14] gh-132835: Add defensive NULL checks to MRO resolution (GH-134763) (GH-140436)

Currently, there are a few places where tp_mro could theoretically
become NULL, but do not in practice. This commit adds defensive checks for
NULL values to ensure that any changes do not introduce a crash and that
state invariants are upheld.

The assertions added in this commit are all instances where a NULL value would get passed to something not expecting a NULL, so it is better to catch an assertion failure than crash later on.

There are a few cases where it is OK for the return of lookup_tp_mro to be NULL, such as when passed to is_subtype_with_mro, which handles this explicitly.
(cherry picked from commit a8edca62fc6d44d16c7f86d49421be1a5ebea3e5)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
Objects/typeobject.c