]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dma-buf/sw-sync: don't enable IRQ from sync_print_obj()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sun, 5 May 2024 14:08:31 +0000 (23:08 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:49 +0000 (13:39 +0200)
commit9d75fab2c14a25553a1664586ed122c316bd1878
treeab774e9639395d61096f87225a58f276b4c54db8
parentd523719e7436f93ad97a50e8f0d4f2dc715699e3
dma-buf/sw-sync: don't enable IRQ from sync_print_obj()

[ Upstream commit b794918961516f667b0c745aebdfebbb8a98df39 ]

Since commit a6aa8fca4d79 ("dma-buf/sw-sync: Reduce irqsave/irqrestore from
known context") by error replaced spin_unlock_irqrestore() with
spin_unlock_irq() for both sync_debugfs_show() and sync_print_obj() despite
sync_print_obj() is called from sync_debugfs_show(), lockdep complains
inconsistent lock state warning.

Use plain spin_{lock,unlock}() for sync_print_obj(), for
sync_debugfs_show() is already using spin_{lock,unlock}_irq().

Reported-by: syzbot <syzbot+a225ee3df7e7f9372dbe@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=a225ee3df7e7f9372dbe
Fixes: a6aa8fca4d79 ("dma-buf/sw-sync: Reduce irqsave/irqrestore from known context")
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/c2e46020-aaa6-4e06-bf73-f05823f913f0@I-love.SAKURA.ne.jp
Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma-buf/sync_debug.c