]> git.ipfire.org Git - thirdparty/coreutils.git/commit
maint: use adaptive approach for `ulimit -v` based tests
authorBernhard Voelker <mail@bernhard-voelker.de>
Tue, 22 Sep 2015 21:23:26 +0000 (23:23 +0200)
committerBernhard Voelker <mail@bernhard-voelker.de>
Tue, 22 Sep 2015 21:23:26 +0000 (23:23 +0200)
commit9db234ad09c12d34d2086057fd92ae448e931ac4
treeaa72ec7b895c3aec9d6a72c986586547768b96cc
parent50e61bfdb9d2df30e1db97ae4ebec7044e087d29
maint: use adaptive approach for `ulimit -v` based tests

When configured with either 'symlinks' or 'shebangs' as value for
the --enable-single-binary option, tests based on `ulimit -v` are
skipped.  The reason is that the multicall 'coreutils' binary requires
much more memory due to shared libraries being loaded, and the size of
the 'date' binary (~290KiB) compared to the multicall binary (~5MiB),
of course.  Finally, in the case of 'shebangs', the starting shell
requires more memory, too

Instead of using hard-coded values for the memory limit, use an
adaptive approach: first determine the amount of memory for a similar,
yet more trivial invocation of the command, and then do the real test
run using that limit (plus some buffer in some cases).

* init.cfg (require_ulimit_v_): Remove function.
(get_min_ulimit_v_): Add function to determine the minimum memory limit
required for a given command in an adaptive way.
* cfg.mk (sc_prohibit_test_ulimit_without_require_): Change the name
of the above function in the syntax-check rule.
* tests/cp/link-heap.sh: Use the above function to determine the
minimum memory required to run a command simpler than in the real test
run.  Use that limit plus a buffer there.  While at it, change to list
of commands in the subshell to fail also if the beginning `ulimit -v`
fails.
* tests/dd/no-allocate.sh: Likewise.
* tests/misc/csplit-heap.sh: Likewise.
* tests/misc/cut-huge-range.sh: Likewise.
* tests/misc/head-c.sh: Likewise.
* tests/misc/printf-surprise.sh: Likewise.
* tests/split/line-bytes.sh: Likewise.
* tests/rm/many-dir-entries-vs-OOM.sh: Likewise - doing it separately
for each program under test.
cfg.mk
init.cfg
tests/cp/link-heap.sh
tests/dd/no-allocate.sh
tests/misc/csplit-heap.sh
tests/misc/cut-huge-range.sh
tests/misc/head-c.sh
tests/misc/printf-surprise.sh
tests/rm/many-dir-entries-vs-OOM.sh
tests/split/line-bytes.sh