]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: dvb-usb-v2: lmedm04: Fix firmware macro definitions
authorKees Cook <kees@kernel.org>
Fri, 10 Oct 2025 03:06:07 +0000 (20:06 -0700)
committerDaniel Gomez <da.gomez@samsung.com>
Wed, 5 Nov 2025 13:08:55 +0000 (14:08 +0100)
commit9de2198ab975a07c1160e8ece6a28a41fdff2cfd
treea2c2acbe93232be1e1fadd48beabd31b825a95b6
parentee3b8134b2bae848e03e56c090ceca4ae76cee06
media: dvb-usb-v2: lmedm04: Fix firmware macro definitions

The firmware filename macros incorrectly included semicolons in their
string literal definitions. Right now, this wasn't causing any real
problem, but coming changes to the MODULE_INFO() macro make this more
sensitive. Specifically, when used with MODULE_FIRMWARE(), this
created syntax errors during macro expansion:

    MODULE_FIRMWARE(LME2510_C_S7395);

expands to:

    MODULE_INFO(firmware, "dvb-usb-lme2510c-s7395.fw";)
                                                     ^
                                          syntax error

Remove the trailing semicolons from all six firmware filename macro
definitions. Semicolons should only appear at the point of use, not in
the macro definition.

Reviewed-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Tested-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
drivers/media/usb/dvb-usb-v2/lmedm04.c