]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
dont qualify literal_binds with literal_execute
authorMike Bayer <mike_mp@zzzcomputing.com>
Sat, 7 Aug 2021 15:02:59 +0000 (11:02 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sat, 7 Aug 2021 16:13:57 +0000 (12:13 -0400)
commit9de57843a3a98555df21b5c5585f8af699d8ec2e
treecaeb4640b6be9e05d0bdfbbf5bd99561cc5e9622
parentb75630cec9418ef087e7c6af0370ac6ba728a251
dont qualify literal_binds with literal_execute

this appears to be unnecessary and prevents end-user
literal_binds case from working.

Fixed issue where the ``literal_binds`` compiler flag, as used externally
to render bound parameters inline, would fail to work when used with a
certain class of parameters known as "literal_execute", which covers things
like LIMIT and OFFSET values for dialects where the drivers don't allow a
bound parameter, such as SQL Server's "TOP" clause.  The issue locally
seemed to affect only the MSSQL dialect.

Fixes: #6863
Change-Id: Ia74cff5b0107b129a11b9b965883552b2962e449
doc/build/changelog/unreleased_14/6863.rst [new file with mode: 0644]
lib/sqlalchemy/sql/compiler.py
test/dialect/mssql/test_compiler.py
test/dialect/oracle/test_compiler.py
test/sql/test_compiler.py