]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
i2c: mux: demux-pinctrl: do not deactivate a master that is not active
authorPeter Rosin <peda@axentia.se>
Wed, 2 Mar 2022 11:22:35 +0000 (12:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:06:36 +0000 (09:06 +0200)
commit9e398155d182601f893fa45c5d19acd0b3cbb733
tree15cd3c14a6a4a57f14ce76a7db2ccd2e12462f0a
parente1c5d46f05aa23d740daae5cd3a6472145afac42
i2c: mux: demux-pinctrl: do not deactivate a master that is not active

[ Upstream commit 1a22aabf20adf89cb216f566913196128766f25b ]

Attempting to rollback the activation of the current master when
the current master has not been activated is bad. priv->cur_chan
and priv->cur_adap are both still zeroed out and the rollback
may result in attempts to revert an of changeset that has not been
applied and do result in calls to both del and put the zeroed out
i2c_adapter. Maybe it crashes, or whatever, but it's bad in any
case.

Fixes: e9d1a0a41d44 ("i2c: mux: demux-pinctrl: Fix an error handling path in 'i2c_demux_pinctrl_probe()'")
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i2c/muxes/i2c-demux-pinctrl.c