]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bnx2x: fix potential memory leak in bnx2x_tpa_stop()
authorJianglei Nie <niejianglei2021@163.com>
Fri, 30 Sep 2022 06:28:43 +0000 (14:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:15:40 +0000 (13:15 +0200)
commit9ec3f783f08b57a861700fdf4d3d8f3cfb68f471
treea14d6708b9a81eeef7fdec0a3bd76151c4ba7fd6
parent5d2ba255e93211e541373469dffbda7c99dfa0e5
bnx2x: fix potential memory leak in bnx2x_tpa_stop()

[ Upstream commit b43f9acbb8942b05252be83ac25a81cec70cc192 ]

bnx2x_tpa_stop() allocates a memory chunk from new_data with
bnx2x_frag_alloc(). The new_data should be freed when gets some error.
But when "pad + len > fp->rx_buf_size" is true, bnx2x_tpa_stop() returns
without releasing the new_data, which will lead to a memory leak.

We should free the new_data with bnx2x_frag_free() when "pad + len >
fp->rx_buf_size" is true.

Fixes: 07b0f00964def8af9321cfd6c4a7e84f6362f728 ("bnx2x: fix possible panic under memory stress")
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c