]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
staging: gpib: Fix inadvertent negative shift
authorDave Penkler <dpenkler@gmail.com>
Thu, 16 Jan 2025 11:00:14 +0000 (12:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Jan 2025 12:23:35 +0000 (13:23 +0100)
commit9ed145e64f0af9a22e95f79940c540affbd939e2
treea5d79983b5402e35c7ec306186f3ddc36d957d4c
parentd3fbbfa925c25d4d4453236173fb459ae2990265
staging: gpib: Fix inadvertent negative shift

During the initial checkpatch cleanup, when removing blanks
after open parentheses, a minus sign in the argument of a shift
operation was deleted by mistake. This transformed a pre-decrement
operation into a negation.

The result of a negative shift is undefined and a warning was
signalled by sparse.

Restore the pre-decrement operation.

Fixes: 6c52d5e3cde2 ("staging: gpib: Add common include files for GPIB drivers")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250116110014.15577-1-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/include/amcc5920.h