]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ARM: 8579/1: mm: Fix definition of pmd_mknotpresent
authorSteve Capper <steve.capper@arm.com>
Tue, 7 Jun 2016 16:58:06 +0000 (17:58 +0100)
committerJiri Slaby <jslaby@suse.cz>
Fri, 19 Aug 2016 07:51:16 +0000 (09:51 +0200)
commit9f7a3b9e35ce37e2f5802b95bad06dd3781e2dc7
tree5ae833e04e66ea639d279d1d4eb46f54f60166f8
parent4c81fa37349757cc1c32ef261ab187ed43e72d1e
ARM: 8579/1: mm: Fix definition of pmd_mknotpresent

commit 56530f5d2ddc9b9fade7ef8db9cb886e9dc689b5 upstream.

Currently pmd_mknotpresent will use a zero entry to respresent an
invalidated pmd.

Unfortunately this definition clashes with pmd_none, thus it is
possible for a race condition to occur if zap_pmd_range sees pmd_none
whilst __split_huge_pmd_locked is running too with pmdp_invalidate
just called.

This patch fixes the race condition by modifying pmd_mknotpresent to
create non-zero faulting entries (as is done in other architectures),
removing the ambiguity with pmd_none.

[catalin.marinas@arm.com: using L_PMD_SECT_VALID instead of PMD_TYPE_SECT]

Fixes: 8d9625070073 ("ARM: mm: Transparent huge page support for LPAE systems.")
Reported-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Steve Capper <steve.capper@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/arm/include/asm/pgtable-3level.h