]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mm/mincore: improve performance by adding an unlikely hint
authorColin Ian King <colin.i.king@gmail.com>
Wed, 19 Feb 2025 08:36:07 +0000 (08:36 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Mar 2025 05:06:32 +0000 (22:06 -0700)
commit9fa26fb554baaf71826814804749f5cff130c4d6
tree0b579f5622a3f2090bafc7a8cbf81937bd62795d
parent375c28a0df0ee8869d0980228d659d91f85455f9
mm/mincore: improve performance by adding an unlikely hint

Adding an unlikely() hint on the masked start comparison error return path
improves run-time performance of the mincore system call.

Benchmarking on an i9-12900 shows an improvement of 7ns on mincore calls
on a 256KB mmap'd region where 50% of the pages we resident.  Improvement
was from ~970 ns down to 963 ns, so a small ~0.7% improvement.

Results based on running 20 tests with turbo disabled (to reduce clock
freq turbo changes), with 10 second run per test and comparing the number
of mincores calls per second.  The % standard deviation of the 20 tests
was ~0.10%, so results are reliable.

Link: https://lkml.kernel.org/r/20250219083607.5183-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Cc: Matthew Wilcow <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/mincore.c