]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
binfmt_flat: Fix integer overflow bug on 32 bit systems
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 4 Dec 2024 12:07:15 +0000 (15:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Feb 2025 09:05:04 +0000 (10:05 +0100)
commita009378af674b808efcca1e2e67916e79ce866b3
tree4070018bbad48f6d110f74f0ecf31a4c8fc58169
parentf735c9d4dc938eee079894ca4fcac4a286591f7b
binfmt_flat: Fix integer overflow bug on 32 bit systems

commit 55cf2f4b945f6a6416cc2524ba740b83cc9af25a upstream.

Most of these sizes and counts are capped at 256MB so the math doesn't
result in an integer overflow.  The "relocs" count needs to be checked
as well.  Otherwise on 32bit systems the calculation of "full_data"
could be wrong.

full_data = data_len + relocs * sizeof(unsigned long);

Fixes: c995ee28d29d ("binfmt_flat: prevent kernel dammage from corrupted executable headers")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
Link: https://lore.kernel.org/r/5be17f6c-5338-43be-91ef-650153b975cb@stanley.mountain
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/binfmt_flat.c