]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tomoyo: don't emit warning in tomoyo_write_control()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Mon, 16 Dec 2024 10:38:40 +0000 (19:38 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Feb 2025 12:49:31 +0000 (13:49 +0100)
commita01c200fa7eb59da4d2dbbb48b61f4a0d196c09f
tree1efb4fef79fae380406341e28485c5592df43ebb
parentada9df08b3ef683507e75b92f522fb659260147f
tomoyo: don't emit warning in tomoyo_write_control()

[ Upstream commit 3df7546fc03b8f004eee0b9e3256369f7d096685 ]

syzbot is reporting too large allocation warning at tomoyo_write_control(),
for one can write a very very long line without new line character. To fix
this warning, I use __GFP_NOWARN rather than checking for KMALLOC_MAX_SIZE,
for practically a valid line should be always shorter than 32KB where the
"too small to fail" memory-allocation rule applies.

One might try to write a valid line that is longer than 32KB, but such
request will likely fail with -ENOMEM. Therefore, I feel that separately
returning -EINVAL when a line is longer than KMALLOC_MAX_SIZE is redundant.
There is no need to distinguish over-32KB and over-KMALLOC_MAX_SIZE.

Reported-by: syzbot+7536f77535e5210a5c76@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=7536f77535e5210a5c76
Reported-by: Leo Stone <leocstone@gmail.com>
Closes: https://lkml.kernel.org/r/20241216021459.178759-2-leocstone@gmail.com
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Sasha Levin <sashal@kernel.org>
security/tomoyo/common.c