]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NTB: fix possible name leak in ntb_register_device()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 1 Dec 2023 03:30:56 +0000 (11:30 +0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:48 +0000 (18:19 -0400)
commita039690d323221eb5865f1f31db3ec264e7a14b6
tree4eea0e76d1a97e7e236482a8b2c599036bbd7074
parentfad132306512579a24f955db3f3bad2fbaf9f660
NTB: fix possible name leak in ntb_register_device()

[ Upstream commit aebfdfe39b9327a3077d0df8db3beb3160c9bdd0 ]

If device_register() fails in ntb_register_device(), the device name
allocated by dev_set_name() should be freed. As per the comment in
device_register(), callers should use put_device() to give up the
reference in the error path. So fix this by calling put_device() in the
error path so that the name can be freed in kobject_cleanup().

As a result of this, put_device() in the error path of
ntb_register_device() is removed and the actual error is returned.

Fixes: a1bd3baeb2f1 ("NTB: Add NTB hardware abstraction layer")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20231201033057.1399131-1-yangyingliang@huaweicloud.com
[mani: reworded commit message]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ntb/core.c
drivers/pci/endpoint/functions/pci-epf-vntb.c