]> git.ipfire.org Git - thirdparty/gcc.git/commit
vect: Don't retry if the previous analysis fails
authorKewen Lin <linkw@linux.ibm.com>
Wed, 17 May 2023 07:48:40 +0000 (02:48 -0500)
committerKewen Lin <linkw@linux.ibm.com>
Wed, 17 May 2023 07:48:40 +0000 (02:48 -0500)
commita04bf39f61ce7814d197d712760f08c206daf4f1
treee64824b0486009a69cb6c5f1d1755917441c3c49
parente0f2f4711794e3117db9e97164c674bd96a52fe6
vect: Don't retry if the previous analysis fails

When working on a cost tweaking patch, I found that a newly
added test case has different dumpings with stage-1 and
bootstrapped gcc.  By looking into it, the apparent reason
is vect_analyze_loop_2 doesn't get slp_done_for_suggested_uf
set expectedly, the following retrying will use the garbage
slp_done_for_suggested_uf instead.  In fact, the setting of
slp_done_for_suggested_uf only happens when the previous
analysis succeeds, for the mentioned test case, its previous
analysis does fail, it's unexpected to use the value of
slp_done_for_suggested_uf any more.

In function vect_analyze_loop_1, we only return success when
res is true, which is the result of 1st analysis.  It means
we never try to vectorize with unroll_vinfo if the previous
analysis fails.  So this patch shouldn't break anything, and
just stop some useless analysis early.

gcc/ChangeLog:

* tree-vect-loop.cc (vect_analyze_loop_1): Don't retry analysis with
suggested unroll factor once the previous analysis fails.
gcc/tree-vect-loop.cc