]> git.ipfire.org Git - thirdparty/samba.git/commit
s3:rpc_server: Make sure struct security_ace is initialized
authorAndreas Schneider <asn@samba.org>
Tue, 18 Jun 2024 13:57:45 +0000 (15:57 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Mon, 24 Jun 2024 06:14:35 +0000 (06:14 +0000)
commita0b6d18a254b77a6d236390a2b21beb61ec4ba5b
tree779180c8aaeac350f55b72779552850976c34713
parentc709cb8a17cb1d441c598b9e894f55a3f16bd6df
s3:rpc_server: Make sure struct security_ace is initialized

Found by Covscan.

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/rpc_server/samr/srv_samr_nt.c:235: var_decl: Declaring variable ""ace"" without initializer.
samba-4.20.0rc2/source3/rpc_server/samr/srv_samr_nt.c:269: uninit_use_in_call: Using uninitialized value ""*ace"". Field ""ace->object"" is uninitialized when calling ""make_sec_acl"".
  267|    /* create the security descriptor */
  268|
  269|->  if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, i, ace)) == NULL)
  270|    return NT_STATUS_NO_MEMORY;
  271|"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
source3/rpc_server/samr/srv_samr_nt.c