]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iommu/amd: Fix potential out-of-bounds read in iommu_mmio_show
authorSongtang Liu <liusongtang@bytedance.com>
Fri, 31 Oct 2025 05:55:25 +0000 (22:55 -0700)
committerJoerg Roedel <joerg.roedel@amd.com>
Tue, 4 Nov 2025 10:06:00 +0000 (11:06 +0100)
commita0c7005333f9a968abb058b1d77bbcd7fb7fd1e7
tree7e5864a83d418bbbd20183e077719f472e08f09e
parentdcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
iommu/amd: Fix potential out-of-bounds read in iommu_mmio_show

In iommu_mmio_write(), it validates the user-provided offset with the
check: `iommu->dbg_mmio_offset > iommu->mmio_phys_end - 4`.
This assumes a 4-byte access. However, the corresponding
show handler, iommu_mmio_show(), uses readq() to perform an 8-byte
(64-bit) read.

If a user provides an offset equal to `mmio_phys_end - 4`, the check
passes, and will lead to a 4-byte out-of-bounds read.

Fix this by adjusting the boundary check to use sizeof(u64), which
corresponds to the size of the readq() operation.

Fixes: 7a4ee419e8c1 ("iommu/amd: Add debugfs support to dump IOMMU MMIO registers")
Signed-off-by: Songtang Liu <liusongtang@bytedance.com>
Reviewed-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Tested-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/amd/debugfs.c