]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cpufreq: s5pv210: fix refcount leak
authorShuhao Fu <sfual@cse.ust.hk>
Sun, 5 Oct 2025 19:31:17 +0000 (03:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jan 2026 12:09:42 +0000 (13:09 +0100)
commita0f5ffc01af548be764485d26a9f1c7520b01756
treea9ee0f95881f05ad4a8c8927f4b8942655056b5f
parent08ba2b9983ad4a60560a42f797e27a054f07a36e
cpufreq: s5pv210: fix refcount leak

[ Upstream commit 2de5cb96060a1664880d65b120e59485a73588a8 ]

In function `s5pv210_cpu_init`, a possible refcount inconsistency has
been identified, causing a resource leak.

Why it is a bug:
1. For every clk_get, there should be a matching clk_put on every
successive error handling path.
2. After calling `clk_get(dmc1_clk)`, variable `dmc1_clk` will not be
freed even if any error happens.

How it is fixed: For every failed path, an extra goto label is added to
ensure `dmc1_clk` will be freed regardlessly.

Signed-off-by: Shuhao Fu <sfual@cse.ust.hk>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cpufreq/s5pv210-cpufreq.c