]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Move safewrite and saferead to a separate file.
authorJim Meyering <meyering@redhat.com>
Fri, 22 Feb 2008 15:53:13 +0000 (15:53 +0000)
committerJim Meyering <meyering@redhat.com>
Fri, 22 Feb 2008 15:53:13 +0000 (15:53 +0000)
commita178a4e7bfa748f13efe0635eb5adf0c5e6fcb2f
tree6d1205f59552ea3656bc6dd494bcb4384a043690
parent6187c6de9b16af680a9ac73ec29bd254e8f09f41
Move safewrite and saferead to a separate file.

We currently use safewrite from inside libvirt and don't want to publish
any such function name.  However, we do want to use it in applications
like virsh, libvirtd and libvirt_proxy that link with libvirt.  To that
end, this change moves that function definition (along with the nearly
identical saferead) into a new file, util-lib.c.  To avoid maintaining
separate copies of even such small functions, we simply include that new
file from util.c.  Then, the separate applications that need to use
safewrite simply compile and link with util-lib.c.

Of course, this does mean that each of those applications will
containing two copies of these functions.  However, the functions
are so small that it's not worth worrying about that.

* src/util.c (saferead, safewrite): Move function definitions to
util-lib.c and include that .c file.
* src/util-lib.c (saferead, safewrite): New file.  Functions from src/util.c
with slight change (s/int r =/ssize_t r =/) to reflect read/write return type.
* src/util-lib.h: Declare the two moved functions.
* src/util.h: Remove declarations.  Include src/util-lib.h.
* proxy/Makefile.am (libvirt_proxy_SOURCES): Add src/util-lib.c.
* qemud/Makefile.am (libvirtd_SOURCES): Likewise.
* src/Makefile.am (virsh_SOURCES): Add util-lib.c.  Remove some SP-before-TAB.
ChangeLog
proxy/Makefile.am
proxy/libvirt_proxy.c
qemud/Makefile.am
src/Makefile.am
src/util-lib.c [new file with mode: 0644]
src/util-lib.h [new file with mode: 0644]
src/util.c
src/util.h