]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hsr: Prevent use after free in prp_create_tagged_frame()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 27 Oct 2023 12:19:01 +0000 (15:19 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:08:28 +0000 (11:08 +0100)
commita1a485e45d24b1cd8fe834fd6f1b06e2903827da
tree0b8ccaee406b0baa3b08faf7bbae8e65ccd29c10
parent352887b3edd007cf9b0abc30fe9d98622acd859b
hsr: Prevent use after free in prp_create_tagged_frame()

[ Upstream commit 876f8ab52363f649bcc74072157dfd7adfbabc0d ]

The prp_fill_rct() function can fail.  In that situation, it frees the
skb and returns NULL.  Meanwhile on the success path, it returns the
original skb.  So it's straight forward to fix bug by using the returned
value.

Fixes: 451d8123f897 ("net: prp: add packet handling support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/57af1f28-7f57-4a96-bcd3-b7a0f2340845@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/hsr/hsr_forward.c