]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: check dev->gso_max_size in gso_features_check()
authorEric Dumazet <edumazet@google.com>
Tue, 19 Dec 2023 12:53:31 +0000 (12:53 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jan 2024 14:13:30 +0000 (15:13 +0100)
commita1ab650f1421af85657b436ec10e6cd7b9e43b0c
tree462eac02c88e328b0efa21649307520168f1184e
parent56eaa3ec314098a18ed935313268679a1e3ccd9a
net: check dev->gso_max_size in gso_features_check()

[ Upstream commit 24ab059d2ebd62fdccc43794796f6ffbabe49ebc ]

Some drivers might misbehave if TSO packets get too big.

GVE for instance uses a 16bit field in its TX descriptor,
and will do bad things if a packet is bigger than 2^16 bytes.

Linux TCP stack honors dev->gso_max_size, but there are
other ways for too big packets to reach an ndo_start_xmit()
handler : virtio_net, af_packet, GRO...

Add a generic check in gso_features_check() and fallback
to GSO when needed.

gso_max_size was added in the blamed commit.

Fixes: 82cc1a7a5687 ("[NET]: Add per-connection option to set max TSO frame size")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20231219125331.4127498-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/dev.c