]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
irqchip: atmel-aic: Fix irqdomain initialization
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Tue, 11 Nov 2014 13:33:36 +0000 (14:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Dec 2014 23:57:32 +0000 (15:57 -0800)
commita1d50bd9bd15eded3812bc9ac1bca6875772fbb7
tree867f7a7dad8f9c3b42a12308206b95e7497042ed
parent461692058ec81c61ce2642097d256ffcaf8897cf
irqchip: atmel-aic: Fix irqdomain initialization

commit 45977fe35bf014f5cf9552717e1320783398ae0d upstream.

First of all IRQCHIP_SKIP_SET_WAKE is not a valid irq_gc_flags and thus
should not be passed as the last argument of
irq_alloc_domain_generic_chips.

Then pass the correct handler (handle_fasteoi_irq) to
irq_alloc_domain_generic_chips instead of manually re-setting it in the
initialization loop.

And eventually initialize default irq flags to the pseudo standard:
IRQ_REQUEST | IRQ_PROBE | IRQ_AUTOEN.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
Fixes: b1479ebb77200 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers")
Link: https://lkml.kernel.org/r/1415712816-9202-1-git-send-email-boris.brezillon@free-electrons.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/irqchip/irq-atmel-aic-common.c