]> git.ipfire.org Git - thirdparty/linux.git/commit
media: mali-c55: Disable pm_runtime on probe error
authorDavid Carlier <devnexen@gmail.com>
Sat, 28 Mar 2026 15:14:52 +0000 (15:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 19 May 2026 07:01:50 +0000 (09:01 +0200)
commita1db83cc6f7e88a166c77d9060507ec01d617784
tree91dd508d76dd2898f1d974e459ccdd99ad82ea1e
parent2c9b9bcc2569f52e366ec71ca012542e161f1f8d
media: mali-c55: Disable pm_runtime on probe error

When mali_c55_media_frameworks_init() fails, the goto target jumps to
err_free_context_registers, skipping pm_runtime_disable() despite
pm_runtime having already been enabled earlier in the function.

Fix this by adding an err_pm_runtime_disable label and redirecting the
frameworks init failure to it, so pm_runtime is properly unwound on
that error path. The runtime PM status is also set back to suspended
before disabling, to undo the pm_runtime_set_active() from probe.

Cc: stable@vger.kernel.org
Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver")
Signed-off-by: David Carlier <devnexen@gmail.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/arm/mali-c55/mali-c55-core.c