]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: Fix missing error handling for get_min_max*()
authorTakashi Iwai <tiwai@suse.de>
Tue, 14 Apr 2026 09:33:34 +0000 (11:33 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 14 Apr 2026 10:30:51 +0000 (12:30 +0200)
commita1ed2ec1c5458b4a99765439cb595dd0e026a352
tree0c49fd454bd30b00e4d0ff14a80848fb40fa5780
parent46c862f5419e0a86b60b9f9558d247f6084c99f9
ALSA: usb-audio: Fix missing error handling for get_min_max*()

The recent fix to add the error return value check from get_min_max*()
missed one case in build_audio_procunit() where no error value is set.
This may lead to an uninitialized variable and confuse the caller
(although this wouldn't happen practically because err is set for the
loop of num_ins at the beginning of the funciton).

Fix it by setting "err = 0" properly at the missing case, too.

Fixes: 4f55a85cd4fc ("ALSA: usb-audio: Add error checks against get_min_max*()")
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/ad36dGpCBTGsyFr_@stanley.mountain
Link: https://patch.msgid.link/20260414093336.305464-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c